Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add filter and transformation support to breakdown / attrition endpoint #126

Merged
merged 6 commits into from
Mar 4, 2025
Merged

Feat: add filter and transformation support to breakdown / attrition endpoint #126

merged 6 commits into from
Mar 4, 2025

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Jan 31, 2025 •
edited
Loading

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1642

New Features

  • add support for the new "filters" and "transformation" sections to various endpoints

Breaking changes

  • The endpoint /cohort-stats/by-source-id/:sourceid/by-cohort-definition-id/:cohortid/by-concept-id/:conceptid is now adjusted to /cohort-stats/by-source-id/:sourceid/by-cohort-definition-id/:cohortid and the concept to get stats on should be the last variable in the POST request body

@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@pieterlukasse pieterlukasse changed the title feat: add filter and transformation support to breakdown / attrition endpoint Feat: add filter and transformation support to breakdown / attrition endpoint Jan 31, 2025
@pieterlukasse pieterlukasse force-pushed the feat/add_filter_and_transformation_to_remaining_endpoints branch from 59fb8c8 to 4826d19 Compare February 8, 2025 10:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions GitHub Actions
Copy link

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions GitHub Actions
Copy link

Please find the ci env pod logs here

@pieterlukasse pieterlukasse force-pushed the feat/support_filters_and_transformation branch from 0ac4088 to 859816c Compare February 11, 2025 15:56
@pieterlukasse pieterlukasse force-pushed the feat/add_filter_and_transformation_to_remaining_endpoints branch from e7413ab to 2bd4881 Compare February 11, 2025 16:34
@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Base automatically changed from feat/support_filters_and_transformation to master February 11, 2025 18:10
@pieterlukasse pieterlukasse changed the base branch from master to feat/support_filters_and_transformation February 11, 2025 18:29
Base automatically changed from feat/support_filters_and_transformation to feat/filters_and_transformation_main February 11, 2025 18:30
@pieterlukasse pieterlukasse force-pushed the feat/add_filter_and_transformation_to_remaining_endpoints branch from 2bd4881 to 1fd5ac9 Compare February 11, 2025 18:38
@pieterlukasse
feat: add filter and transformation support to breakdown / attrition …
2c9901b 
…endpoint

Also:
- feat: update RetrieveStatsForCohortIdAndConceptId and remove deprecated method
- feat: refactor RetrieveCohortOverlapStats and fix breakdown stats method
...and fix model tests
- feat: comment on a comment
...see also #5 (comment)
- feat: refactor RetrieveDataBySourceIdAndCohortIdAndVariables
... and deprecate model method in favor of the histogram one
that retrieves the same data but is already refactored.
- feat: remove deprecated breakdown stats method
@pieterlukasse pieterlukasse force-pushed the feat/add_filter_and_transformation_to_remaining_endpoints branch from 1fd5ac9 to 2c9901b Compare February 11, 2025 18:43
@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@pieterlukasse pieterlukasse marked this pull request as ready for review February 11, 2025 19:25
@pieterlukasse pieterlukasse requested a review from tianj7 February 11, 2025 19:25
@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions GitHub Actions
Copy link

Please find the ci env pod logs here

@pieterlukasse pieterlukasse mentioned this pull request Feb 13, 2025
Merged
tianj7
tianj7 reviewed Feb 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_homepage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

tianj7
tianj7 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pieterlukasse pieterlukasse merged commit 326d2ff into feat/filters_and_transformation_main Mar 4, 2025
9 of 11 checks passed
@pieterlukasse pieterlukasse deleted the feat/add_filter_and_transformation_to_remaining_endpoints branch March 4, 2025 20:36
@pieterlukasse pieterlukasse mentioned this pull request Mar 5, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianj7 tianj7 tianj7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @tianj7